Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accessibility] Interactive markers should be role="button" #11031

Closed
Malvoz opened this issue Sep 18, 2021 · 1 comment · Fixed by #11064
Closed

[accessibility] Interactive markers should be role="button" #11031

Malvoz opened this issue Sep 18, 2021 · 1 comment · Fixed by #11064
Assignees
Milestone

Comments

@Malvoz
Copy link

Malvoz commented Sep 18, 2021

Interactive markers (e.g. markers that bind to popups) are focusable and actionable elements, and should have appropriate semantics (i.e. role="button").

Related WCAG 2.1 Success Criterion: 4.1.2 Name, Role, Value (this issue is to address the Role part of the Success Criterion for interactive markers).

@Malvoz Malvoz changed the title Interactive markers should be role="button" [accessibility] Interactive markers should be role="button" Sep 18, 2021
@mourner mourner added this to the accessibility milestone Sep 20, 2021
@DillonKyleDev
Copy link

Hello, @mourner and @Malvoz!

I would love to help contribute to this project! I wanted to fork and clone the repo to get a feel for the code base before commenting on a specific issue, but I'm facing some difficulties getting the project up and running locally.
I am stuck at the step:

Install headless-gl dependencies https://github.com/stackgl/headless-gl#windows

In vsCode when I enter:
copy node_modules/headless-gl/deps/windows/dll/x64/*.dll c:\windows\system32

I get the error:
copy : Cannot find path 'C:\Users\dillo\gitRepos\Mapbox\mapbox-gl-js\node_modules\headless-gl\deps\windows\dll\x64' because it does not exist.

I believe I have all the packages installed correctly, any insight would be greatly appreciated!

@avpeery avpeery self-assigned this Sep 24, 2021
@avpeery avpeery linked a pull request Sep 29, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants