Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "SourceCache" #2291

Closed
lucaswoj opened this issue Mar 18, 2016 · 3 comments
Closed

Refactor "SourceCache" #2291

lucaswoj opened this issue Mar 18, 2016 · 3 comments

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Mar 18, 2016

The SourceCache class could use a big refactor (maybe even a ground-up rewrite) to

  • simplify and fix bugs in our wrapped tile retention system Ensure SourceCache reuses tiles across the dateline #1834
  • simplify our tile caching system to make it easier to reason about
  • create a cleaner API (the class currently includes some overly-complex methods, surprising side effects, and too-long argument lists)
  • improve testability
  • move all code that isn't related to tile caching into separate modules

ref #2287

@jfirebaugh
Copy link
Contributor

I think we should wholly revert the relationship inversion between Source and TilePyramid/SourceCache. Judging by the resulting complex coupling, this seems to have been an architectural mistake.

@anandthakker
Copy link
Contributor

@jfirebaugh can you say more about this? I agree that the current coupling is not ideal, but it's not clear to me that inverting the dependencies would really eliminate it. Would another way to improve this might be to clarify and simplify the Source interface?

@mourner
Copy link
Member

mourner commented Sep 11, 2019

Closing as too vague — we should create new issues for any specific things we can improve.

@mourner mourner closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants