Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DDS support for "text-offset" #4435

Closed
ericrwolfe opened this issue Mar 16, 2017 · 1 comment · Fixed by #4495
Closed

Add DDS support for "text-offset" #4435

ericrwolfe opened this issue Mar 16, 2017 · 1 comment · Fixed by #4495
Assignees
@mollymerp
Labels
cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) feature 🍏

Comments

@ericrwolfe
Copy link

DDS support for text-offset should go hand in hand with icon-size #4228.

Primary use case: When a symbol layer contains both text and an icon, and icon-size is driven by a DDS function, the text-offset will likely need to change to handle the dynamic icon size.

Similar to the already-implemented icon-offset #3791.
@ericrwolfe ericrwolfe added cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) feature 🍏 labels Mar 16, 2017
@jfirebaugh jfirebaugh mentioned this issue Mar 16, 2017
Open
@anandthakker
Copy link
Contributor

Great point @ericfischer

@mollymerp mollymerp self-assigned this Mar 25, 2017
@mollymerp mollymerp mentioned this issue Mar 25, 2017
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mollymerp mollymerp

Labels
cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) feature 🍏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add dds support for text-offset mapbox/mapbox-gl-js
3 participants
@ericrwolfe @mollymerp @anandthakker