-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LAB/HSL color interpolation for expressions #5326
Comments
Another option would be to roll back expressions-based stop functions conversion until we reach feature and performance parity. |
Oops, I intended to ticket this follow-up, but forgot to -- thanks @mourner . @jfirebaugh had an idea about removing the |
Hmm, how would that look? |
Yeah, I think in order to use that approach we'd probably have to broaden the idea of what the transition properties are for. The advantage, though, is that there would be a consistent way to control color interpolation both for DDS and for the case of transitioning between constant paint property values (e.g. via |
Retitled/de-labeled, given #5379. |
The expressions PR is already merged into master, but it removed support for LAB/HSL
colorSpace
property.We should either add it back before a release (since it's a breaking removal), or remove its support fully (along with
color_spaces.js
and related code) if we don't plan on also implementing it on the Native side.cc @anandthakker @kkaefer
The text was updated successfully, but these errors were encountered: