Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature shows odd white "gap" #7806

Closed
mannnick24 opened this issue Jan 23, 2019 · 8 comments
Closed

feature shows odd white "gap" #7806

mannnick24 opened this issue Jan 23, 2019 · 8 comments
Labels

Comments

@mannnick24
Copy link
Contributor

We are seeing a rendering error at certain zoom levels, with certain features (e.g. Myanmar ) in our new tileset, The geojson looks ok if i examine the raw source geojson at geojsonio site.

in the attached images note the odd white gap. I thought it was to do with generating our tileset with many features together but at the end I tried just turning just that single feature into the tileset and I still seeing this "gap" issue as shown.

(See attached file: PB_MM_R2018_Admin0.json)
(See attached file: GeoJsonCapture.JPG)
(See attached file: MMIssueZoomCapture.JPG)

Here is the tileset (with only country MM in this tile) showing the symptom:
(See attached file: national-181031.mbtiles)

The tippecanoe parameters used are as what suggested from mapbox (from a feedback about what mapbox last used a while ago).

tippecanoe --output=/root/data/tiles/national-181031.mbtiles -y pk -Z 0 -z 12 -pS -pt --buffer=2 --detect-shared-borders -f -l nationalpoly /root/data/tiles/national-181031/*.json

By trial and error if i take out -pS ( --simplify-only-low-zooms ), then the resulted tileset seems ok with this simple example with only just MM in the tileset:

(See attached file: MMAdmin0OKCapture.JPG)

geojsoncapture
GreenlandWhiteLineAppearance.avi.gz
MM issue.avi.gz
mmadmin0okcapture
mmadmin1issecapture
mmissuezoomcapture

However, if I include all the national features to run tippercanoe again without -pS option (was hoping it would solve the problem...), but I still hit the same problem.

Can easily see in this captured video (gzipped avi):
(See attached file: MM issue.avi.gz)

mapbox-gl-js version:

browser:

Steps to Trigger Behavior

Link to Demonstration

https://jsbin.com/

Expected Behavior

Actual Behavior

@mourner
Copy link
Member

mourner commented Jan 23, 2019

This is likely a duplicate of #7023.

@mourner
Copy link
Member

mourner commented Jan 23, 2019

Hmm, if it's tippecanoe-generated tiles and not GeoJSON, this might be a different issue. Would you be able to provide a sample tile that renders incorrectly, or ideally a minimal live test case (e.g. JSFiddle)?

@e-n-f
Copy link
Contributor

e-n-f commented Jan 23, 2019

As the Tippecanoe author, I would urge you not to use --detect-shared-borders, -pS, or -pt, unless there are specific visible discrepancies you are trying to solve with them, since these all inhibit geometric simplifications, thereby making more work for the GL renderer and increasing the odds of aggravating rendering bugs.

@mourner
Copy link
Member

mourner commented Jan 23, 2019

@ericfischer nevertheless, the final tiles go through wagyu, meaning the tiles should contain fully valid polygons, so this might be either a bug in earcut or in wagyu.

@mannnick24
Copy link
Contributor Author

mannnick24 commented Jan 25, 2019

I've saved a fiddle that shows the issue (minus our account token)
https://jsfiddle.net/6ac2rqyw/ I will post the token on ttps://github.com/mapbox/ibm-cognos-collab/issues when I have access

@mannnick24
Copy link
Contributor Author

MM_glitch.zip
Heres an html with the glitching polygon as a geojson source - also with the token removed

@mannnick24
Copy link
Contributor Author

js fiddle moved to https://jsfiddle.net/mannnick/uLa6ncf3/

@mourner
Copy link
Member

mourner commented Feb 4, 2019

@mannnick24 some updates:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants