Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focused control button doesn't defer visually from non-focused #8246

Closed
life777 opened this issue May 14, 2019 · 2 comments · Fixed by #8520
Closed

Focused control button doesn't defer visually from non-focused #8246

life777 opened this issue May 14, 2019 · 2 comments · Fixed by #8520

Comments

@life777
Copy link

life777 commented May 14, 2019

mapbox-gl-js version: 0.54.0

browser: Chome 74 for Linux

Steps to Trigger Behavior

If you have some controls on the map (like zoom controls) and you navigate to them with Tab button you can't distinguish what button is focused now. There are no styles for focused state on the buttons. There should be either outline (like on links in attributions control) or apply hover styles when button is focused.

  1. Open map with zoom control
  2. Navigate with Tab to any zoom button

Link to Demonstration

Example with mapbox:
https://jsbin.com/qemokezepu/edit?html,output

Expected Behavior

Focused buttons should have different styles (or just outline) than non-focused.

Actual Behavior

User can't distinguish what button he/she is currently focused on.

@andrewharvey
Copy link
Collaborator

I'm +1 to having a blue highlight around focused buttons, exactly like GitHub does, which seems to be best practice. Are you interested in putting together a PR?

@life777
Copy link
Author

life777 commented May 15, 2019

Yes, I would love to help you with this case during this week. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants