-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flyTo is broken since v1.2 #8648
Comments
I cannot reproduce this behavior with either of the browsers you listed. I confirmed that I'm using those specific versions of the browsers on MacOS (High Sierra 10.13.6) and I tested the example page you linked. It works as expected. We do manual testing before each release and flyTo animations are something we specifically test because they're so fundamental to GL JS. I'm going to close this for now unless someone can demonstrate that this is definitely not working. |
@vanhumbeecka perhaps you have |
Hey @mourner I can confirm you are correct. On my Mac, the 'Reduce Motion' was indeed activated. I had no idea this also impacts libraries such as mapbox. Toggling this on - and off, indeed activates and deactivates the 'flyTo' mechanism. (Could be usefull to add this note to the example page of flyTo in question?) For future reference, If anyone has the same problem, the setting on MacOS can be found in the Accessibility settings: |
mapbox-gl-js version: 1.2.1
browser:
After upgrading to 1.2.X, the whole 'flyTo' mechanism is broken. There is no standard 'smooth' transition anymore. Change happens instantly without 'flyTo'
Tested in:
Not only in my apps is the transition gone, also on the official example page of Mapbox it is not working>
I can confirm it DOES work in Version 1.1.1
So the bug was introduced in v1.2
Link to Demonstration
Even on the official example page, it is broken:
https://docs.mapbox.com/mapbox-gl-js/example/flyto/
Expected Behavior
flyTo realy "flies" between points. There is no smooth transition now
Actual Behavior
No smooth transition
The text was updated successfully, but these errors were encountered: