Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default benchmark page is broken #9078

Closed
ansis opened this issue Dec 5, 2019 · 1 comment
Closed

default benchmark page is broken #9078

ansis opened this issue Dec 5, 2019 · 1 comment
Labels
workflow 💅

Comments

@ansis
Copy link
Contributor

ansis commented Dec 5, 2019

mapbox-gl-js version: master

browser: all

Steps to Trigger Behavior

  1. yarn run start-bench
  2. open http://localhost:9966/bench/versions

Expected Behavior

Benchmarks run.

Actual Behavior

It tries loading https://s3.amazonaws.com/mapbox-gl-js/v1.7.0-dev/benchmarks.js and errors.

It looks like this is caused by us switching to -dev versions in package.json.
This was referenced Dec 5, 2019
Merged
Merged
@arindam1993
Copy link
Contributor

arindam1993 commented Dec 6, 2019 •
edited
Loading

Along with the -dev postfix, I think the problem is its trying to find the benchmark build for the latest release, which is one increment behind whats in package.json.
The benchmark build for v1.7.0 doesn't exist on S3 yet because that tag hasn't been created yet
I have a quick fix that works ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
workflow 💅
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ansis @arindam1993