-
Notifications
You must be signed in to change notification settings - Fork 1.3k
What is MultiPoint #3288
Comments
Reading into this, yeah, it's a coordinate-container abstract class that's extended by Polygon and Polyline. That shouldn't be the case, it should be named something else and more obviously documented. Also maybe it should be protected? |
Can you show me what you which docs you are referring to?
Where are you reading this? I must admit that I'm also not 💯 on current naming and inheritance. |
It's referred to as a polyline here: https://github.com/mapbox/mapbox-gl-native/blob/master/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/annotations/MultiPoint.java#L28 It's extended at https://github.com/mapbox/mapbox-gl-native/blob/master/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/annotations/Polyline.java and https://github.com/mapbox/mapbox-gl-native/blob/master/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/annotations/Polygon.java There's isn't necessarily a logic problem here, but the usage of MultiPoint really conflicts with its usage elsewhere, in the Simple Features Spec, GeoJSON, and other geo standards. |
@tmcw I'm looking into the possibility to:
|
@tmcw After releasing the directions and geocoder libraries we've noticed that there's some work we need to do to streamline our geographic data structures. See for example the unnecessary conversion we need to do in this example from I want to put some effort into fixing this and I'd love your feedback. What would be in your opinion the best approach here? Would be using the GeoJSON standard as our objects building block the way to go? |
Related: #3630 |
The iOS and OS X SDKs have a similar class naming issue, captured in #5201. |
This change didn't land with |
Removed the current milestone as this requires breaking changes to the api |
Something seems off about this
https://github.com/mapbox/mapbox-gl-native/blob/master/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/annotations/MultiPoint.java
What's up with this?
The text was updated successfully, but these errors were encountered: