Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MGLStyle needs style image accessor #7012

Closed
1ec5 opened this issue Nov 10, 2016 · 2 comments
Closed

MGLStyle needs style image accessor #7012

1ec5 opened this issue Nov 10, 2016 · 2 comments
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Milestone
ios-v3.4.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 10, 2016 •
edited
Loading

MGLStyle has -setImage:forName: and -removeImageForName: methods but no -imageForName: method to get an existing style image. One use case would be to embed a Maki icon from Mapbox Streets into an annotation image (#4750), annotation view, or callout view.

/cc @frederoni @incanus
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling labels Nov 10, 2016
@rmnblm
Copy link

rmnblm commented Nov 11, 2016 •
edited
Loading

I saw this issue and I'm working on it because I was the one who implemented -setImage:forName: and -removeImageForName:

PR coming soon (might have a few questions). 👀

@rmnblm rmnblm mentioned this issue Nov 16, 2016
Merged
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Dec 5, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Dec 6, 2016

Fixed in #7096 on the v3.4.0 release branch.

@1ec5 1ec5 closed this as completed Dec 6, 2016
@1ec5 1ec5 mentioned this issue Dec 6, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Milestone
ios-v3.4.0
Development

No branches or pull requests
2 participants
@1ec5 @rmnblm