Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Per-attribute transition properties on MGLStyleLayer #8010

Closed
1ec5 opened this issue Feb 9, 2017 · 2 comments
Closed

Per-attribute transition properties on MGLStyleLayer #8010

1ec5 opened this issue Feb 9, 2017 · 2 comments
Assignees
Labels
GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Feb 9, 2017

MGLStyleLayer’s concrete subclasses should allow the developer to set transitions that affect individual layout or paint attributes.

We could pair every layout or paint attribute with a transitionFor… property. Or we could fight property proliferation by adding -transitionForKey: and -setTransition:forKey: methods to MGLStyleLayer itself (along the lines of -[CALayer addAnimation:forKey:]). (The downside would be pushing validation of the key until runtime.)

Either way, we should add an MGLTransition class or struct to encapsulate the details of a transition. We’ll want to refine the MGLStyle methods added in #7711 to make use of MGLTransition instead of working with durations and delays directly.

/ref #7863
/cc @incanus @boundsj @jfirebaugh @tobrun

@1ec5 1ec5 added GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling labels Feb 9, 2017
@1ec5 1ec5 added this to the ios-v3.5.0 milestone Feb 9, 2017
@fabian-guerra fabian-guerra self-assigned this Feb 21, 2017
@1ec5
Copy link
Contributor Author

1ec5 commented Feb 23, 2017

mbgl::Layer subclasses expose properties for setting transitions on individual layout and paint properties (example). However, there don’t appear to be any getters. We should add transition getters too.

@boundsj
Copy link
Contributor

boundsj commented Mar 10, 2017

This was added in #8225 that has landed on the release-ios-v3.5.0-android-v5.0.0 release branch and will be in the next iOS 3.5.0 beta 3 release.

@boundsj boundsj closed this as completed Mar 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
GL JS parity For feature parity with Mapbox GL JS iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS runtime styling
Projects
None yet
Development

No branches or pull requests

3 participants