Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GestureSettings] Align the name between Android and iOS #2211

Open
tuyen-vuduc opened this issue Jul 13, 2024 · 1 comment
Open

[GestureSettings] Align the name between Android and iOS #2211

tuyen-vuduc opened this issue Jul 13, 2024 · 1 comment
Labels
bug 🪲 Something is broken!

Comments

@tuyen-vuduc
Copy link

tuyen-vuduc commented Jul 13, 2024

Environment

  • Xcode version: Any
  • iOS version: Any
  • Devices affected: Any
  • Maps SDK Version: 11.5.x

Observed behavior and steps to reproduce

The common properties' names of GestureSettings on iOS are different from the one in Android.

Expected behavior

The common properties's name of GestureSettings should be the same for both platforms

Notes / preliminary analysis

Is this the right mapping?

# Android iOS Aligned
1 rotateEnabled rotateEnabled YES
2 scrollEnabled panEnabled NOPE
3 scrollMode panMode NOPE
4 simultaneousRotateAndPinchToZoomEnabled simultaneousRotateAndPinchZoomEnabled NOPE
5 doubleTouchToZoomOutEnabled doubleTouchToZoomOutEnabled YES
6 doubleTapToZoomInEnabled doubleTapToZoomInEnabled YES
7 focalPoint focalPoint YES
8 pitchEnabled pitchEnabled YES
9 quickZoomEnabled quickZoomEnabled YES
10 pinchScrollEnabled pinchScrollEnabled YES
11 pinchToZoomEnabled N/A NOPE
12 pinchToZoomDecelerationEnabled N/A NOPE
13 rotateDecelerationEnabled N/A NOPE
14 scrollDecelerationEnabled N/A NOPE
15 increaseRotateThresholdWhenPinchingToZoom N/A NOPE
16 increasePinchToZoomThresholdWhenRotating N/A NOPE
17 zoomAnimationAmount N/A NOPE
18 N/A pinchEnabled NOPE
19 N/A pinchZoomEnabled NOPE
20 N/A panDecelerationFactor NOPE

Am I right that (Android)pinchToZoomEnabled = (iOS)PinchEnabled & PinchZoomEnabled?

Additional links and references

N/A

@pjleonard37
Copy link
Contributor

Thanks for sharing this report @tuyen-vuduc. I'll take this back to the team for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something is broken!
Projects
None yet
Development

No branches or pull requests

2 participants