Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler error in Bench — unresolved identifier MapboxVoiceController #2499

Closed
1ec5 opened this issue Jul 28, 2020 · 1 comment · Fixed by #2598
Closed

Compiler error in Bench — unresolved identifier MapboxVoiceController #2499

1ec5 opened this issue Jul 28, 2020 · 1 comment · Fixed by #2598
Labels
build Issues related to builds and dependency management. topic: voice
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jul 28, 2020

#2348 introduced a build error in the BenchTests target:

/path/to/mapbox-navigation-ios/BenchTests/BenchTests.swift:68:31: Use of unresolved identifier 'MapboxVoiceController'

let voiceController = MapboxVoiceController(navigationService: service, speechClient: speechAPI, audioPlayerType: AudioPlayerDummy.self)

This override is intended to capture and record any requests for audio from the Voice API. I think fixing the issue would require either mocking an entire MultiplexedSpeechSynthesizer, which might not give an accurate picture of the number of requests, or exposing a public setter for MapboxSpeechSynthesizer.speech. #2494 introduces a public getter for this property but keeps the setter private.

/cc @mapbox/navigation-ios

@1ec5 1ec5 added build Issues related to builds and dependency management. - tests topic: voice labels Jul 28, 2020
@1ec5 1ec5 added this to the v1.0.0 milestone Jul 28, 2020
@1ec5
Copy link
Contributor Author

1ec5 commented Sep 4, 2020

This is a bit challenging to fix, because #2348 eliminated the ability to inject a type other than AVAudioPlayer to initialize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management. topic: voice
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant