-
Notifications
You must be signed in to change notification settings - Fork 229
Node v0.12.x support #1209
Comments
Been debugging mbstudio vtile exports in person with @BergWerkGIS and @tmpsantos using intel vtune. Preliminary results seem to suggest that windows is launching an extreme number of threads (> 30-40) for exports and causing malloc performance to suffer. Because node v0.12.x uses a libuv version with a new model for threads on windows, I'm picking up this ticket to push it over the edge. The last remaining module needing a tag with node v0.12.x support is node-srs so that is next up. |
@BergWerkGIS - node v0.12.x seems to work: https://travis-ci.org/mapbox/mapbox-studio/builds/58828609. Branch in place to start testing at https://github.com/mapbox/mapbox-studio/compare/node-v12?expand=1. But for your local testing purposes all you need is latest Be aware that https://github.com/mapbox/mapbox-studio/blob/mb-pages/scripts/vendor-node.sh is currently broken but this script is not run on windows, so not a blocker. |
I see no rush to officially move to node v0.12.x, however taking steps to start testing against node v0.12.x would be wise because:
0.12.x might (untested) help solve support for logging on windows via the shell (reverted in Win fix: disable shell logging for windows #1168)To unlock this the C++ module dependencies will need node 0.12.x support/binaries:
The text was updated successfully, but these errors were encountered: