Earcut crashes in certain cases.

[mihakrajnc]

I'm having problems loading a map with the new Earcut dependency. In some cases, the map loads ok, but in other cases it crashes with a NPE.

The crash occurs on this line:

https://github.com/mapbox/mapbox-unity-sdk/blob/develop/sdkproject/Assets/Mapbox/Unity/MeshGeneration/Modifiers/MeshModifiers/Earcut.cs#L490

It looks like there is a null check there, but it does nothing. This seems to be the issue: mapbox/earcut#87

A simple fix for this is to modily the EliminateHoles method like this:

// process holes from left to right
for (i = 0; i < queue.Count; i++)
{
	EliminateHole(queue[i], outerNode);

	Node filterPointsNode = FilterPoints(outerNode, outerNode.next);

	if (filterPointsNode == null) break;

	outerNode = filterPointsNode;
}

But I don't know how correct is this, or what the implications of the change are... Any suggestions?

[david-rhodes]

cc @brnkhy

[brnkhy]

@mihakrajnc I never had such a problem, can you share a sample lat/lng to test it out as well?

[david-rhodes]

@mihakrajnc any updates here?

Can you share a sample lat/lng to test it out as well?

[david-rhodes]

@mihakrajnc closing for now. Please let us know if you find a specific feature that breaks Earcut!