Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitmaps Getting Cut Off #90

Open
mattdesl opened this issue May 7, 2015 · 3 comments
Open

Bitmaps Getting Cut Off #90

mattdesl opened this issue May 7, 2015 · 3 comments
Labels
bug jira-sync-complete

Comments

@mattdesl
Copy link
Contributor

mattdesl commented May 7, 2015

Sorry to keep spamming your inboxes. 😄

I've noticed some artifacts during rendering with the fontnik bitmaps that don't appear with SDFs generated by Hiero. Here is a side-by-side:

fontnik2

I'm guessing the artifacts while rendering may be due to the SDF tiles getting cut off.

Is there some implementation detail that I'm missing?
@mattdesl
Copy link
Contributor Author

mattdesl commented May 7, 2015

Tried building from source and changing the buffer size. It stops getting cut-off but leads to no improvement in the artifacts. 😞

@mikemorris
Copy link
Contributor

Was about to suggest that @mattdesl, I think this could be caused by some of the hardcoded defaults mentioned in #51

@mikemorris mikemorris added the bug label Jul 7, 2015
@mikemorris
Copy link
Contributor

Possible the cutoff is happening as a combination of the buffer and cutoff values?

// Shift the 0 so that we can fit a few negative values
// into our 8 bits.

Bumping up the SDF size may help alleviate some rendering artifacts, as illustrated in #38

@mattdesl mattdesl mentioned this issue Jul 12, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug jira-sync-complete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikemorris @mattdesl @aswamina