Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework build publishing matrix (NAPI v6) #1444

Closed
kewde opened this issue Feb 15, 2021 · 1 comment
Closed

Rework build publishing matrix (NAPI v6) #1444

kewde opened this issue Feb 15, 2021 · 1 comment
Labels
ci pr wanted task

Comments

@kewde
Copy link
Collaborator

kewde commented Feb 15, 2021

Builds for NAPI v6 are not published because the container with Node 11 does not support v6 and wins the race to publishing the builds (v3 only), causing subsequent build containers (Node 12 etc) to fail because v3 already exists. This is a failure of node-pre-gyp.

The recent adoption of NAPI allows for only one container in the build matrix to be responisble for publishing the builds.
kewde added a commit that referenced this issue Feb 15, 2021
@kewde
napi: temporarily disable v6 (see issue #1444)
60a022c
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Merged
@MikeDimmickMnetics MikeDimmickMnetics mentioned this issue Oct 5, 2021
Closed
@chakflying chakflying mentioned this issue Oct 6, 2021
Merged
daniellockyer added a commit that referenced this issue Apr 12, 2022
@daniellockyer
Revert "napi: temporarily disable v6"
a6c893e 
refs #1444

- this reverts commit 60a022c
- we want NAPI v6 builds to be created but they were previously
  temporarily disabled due to a build issue mentioned in the issue above
- I am hoping to fix up the CI builds, so this should no longer be a
  problem
@daniellockyer
Copy link
Member

This should be fixed/no longer relevant 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci pr wanted task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daniellockyer @kewde