-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncompressed mapnik vector tiles are not supported #71
Comments
Would it be feasible for tilelive-vector to check the response headers to see if the tile is compressed? |
As tilelive-vector already invokes I think the straight way would be for Note that any zlib-compressed payload would be recognized as 'pbf' even if it is not... |
This is in the works, see #69. In fact, tilelive-vector will rely on the backend getTile to perform appropriate decompression, and only uncompressed PBFs will be recognized. (This is a breaking change and will come with a semver bump to 3.0.) |
Great, thanks. |
After some deliberation, we're taking a different tack on this, and choosing to move towards treating gzip compression as much more closely tied to the vector tile format itself, with the eventual goal of having "mapnik vector tile" mean "gzip-compressed protobuf". What that means for tilelive-vector is that it will expect to receive a gzipped protobuf from the upstream VT source (deflate support will remain for backward compatibility). It will not support receiving an uncompressed protobuf. |
Thanks, that works in our case, we were already serving gzipped tiles (or uncompressed), just not deflate. |
Also I could be mistaken but I have a vague recollection that uncompressed tiles were being served to TM2 because it wasn't sending an Accept-Encoding header. |
Passing an uncompressed PBF from a backend's getTile is not supported, see:
https://github.com/mapbox/tilelive-vector/blob/master/backend.js#L106-L112
See #70 for full discussion and mapbox/tiletype#4 for a prerequisite to fix this one
The text was updated successfully, but these errors were encountered: