-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove point-feature #35
Comments
Two reasons to keep it:
If you view the library separately from GL JS though, it's indeed weird to have a point type. One thing I considered doing is accepting a point factory in the VT constructor (defaulting to |
I'm assuming we'd convert gl-js to use |
My first point about performance is still valid, and we do a huge ton of coordinate math throughout the code, so rewriting everything for |
Profiling issues like mapbox/mapbox-gl-js#5208, the GC pressure from allocating lots of temporary arrays and tiny objects is substantial. I would like to explore an alternate API for v2 based on either ES6 generators or passing in a function to be called for each geometry element (each ring and point). ES6 generators would be more ergonomic, but a callback approach would be more compatible with legacy browsers (IE11) and also avoid the overhead of |
-> #79 |
The use of point-feature and
{ x, y }
objects seems out of place in such a low-level library. Can we switch to[x, y]
coordinates for 2.0?The text was updated successfully, but these errors were encountered: