Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten nested properties #5

Closed
hannesj opened this issue Aug 12, 2016 · 2 comments
Closed

Flatten nested properties #5

hannesj opened this issue Aug 12, 2016 · 2 comments

Comments

@hannesj
Copy link
Contributor

hannesj commented Aug 12, 2016

Currently if you have an object as a property (e.g. from a GeopJSON-file), it will be stored as [object Object] in the protobuf. It should probably be flattened, e.g. using the dot-notation so that {"name": {"en": "Place"}} would become {"name.en": "Place"}, before storing it.
@anandthakker
Copy link
Contributor

Looks like Mapnik stringifies such values (reference

@hannesj hannesj mentioned this issue Aug 13, 2016
Merged
@hannesj
Copy link
Contributor Author

hannesj commented Aug 13, 2016

That would probably be a good solution in order to be compatible. Did a PR for this (#6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannesj @anandthakker