Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare against PostGIS MakeValid() #47

Open
flippmoke opened this issue Nov 7, 2016 · 2 comments
Open

Compare against PostGIS MakeValid() #47

flippmoke opened this issue Nov 7, 2016 · 2 comments

Comments

@flippmoke
Copy link
Member

flippmoke commented Nov 7, 2016

It would be very interesting to see how Wagyu compares against GEOS/MakeValid in PostGIS both from performance and accuracy. It seems that the method for PostGIS is located here and perhaps it could be extracted and put into a benchmark.

First step would be to determine how to use this method in a standalone fashion if possible.

/cc @pramsey @strk

@Komzpa
Copy link

Komzpa commented Dec 22, 2018

Now that @Algunenano has a branch shipping wagyu into PostGIS postgis/postgis#356 this can be done by writing a PostGIS CUnit test, for example.

@Algunenano
Copy link
Contributor

I did this a while back (months before implementing wagyu inside Postgis):
image

This was comparing our tiler serving MVTs using St_AsMVT or using node-mapnik. The main difference I've noticed when comparing postgis+wagyu and node-mapnik is that node-mapnik drops any inner rings bellow the first one (so inner rings can't have inner rings themselves), while my implementation using wagyu just creates the extra polygons (so the 3rd ring is a new polygon, for example).

I'll probably end up implementing the comparison either with cunit or postgis regress test, so if you are interested in any special case let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants