-
Notifications
You must be signed in to change notification settings - Fork 22
Boost 1.60 #88
Comments
@BergWerkGIS if you are seeing this locally it may be the same problem I had whereby older boost versions were still around and conflicting. I had to clean out my installation directory completely of boost libs and headers and then the problem went away. If you are seeing this remotely on a clean build then it may be that the icu configure check is failing and boost is being built without ICU support. I saw this and came up with this quick fix that enables ICU no matter what the configure check says (which works nicely): https://github.com/mapnik/mapnik-packaging/blob/master/osx/patches/boost_icu_check.diff |
Yes, locally, but I'm 99% percent sure I got rid of all leftovers of previous (boost) builds.
Quite a sophisticated fix 😏 |
@BergWerkGIS still broken or working now? |
@springmeyer still broken. Currently hitting
Despite having added |
Ah, had a typo in Local ( Additionally to AppVeyor I get the errors mentioned in the original post locally. |
Getting those errors with My hunch is that maybe boost doesn't use Any other ideas?
|
@artemp - this looks like something to do with your recent json commits - it will block the release: can you take a look? |
@springmeyer - looks like it doh.. will take a look |
@BergWerkGIS - can you elaborate re: "My hunch is that maybe boost doesn't use C++14 features with VS2015 (hit the same problem with OSRM)." ? What was the issue with OSRM/boost c++14? |
If C++14 features are the problem I could go through AFAIK latest |
Oops, we commented at the same time.
Problem was that OSRM code used some specific C++14 boost features. |
We're not using any c++14 features only c++11. Reading through errors I noticed:
which indicates that perhaps boost is not configured and/or built correctly ? |
Interesting, which ones in particular? OSRM is stuck on C++11 at the moment, I can't remember us doing the switch. |
@daniel-j-h I thought there was a c++14 branch that I tried, didn't I? |
Ah sorry, yes I forgot about Project-OSRM/osrm-backend#1975 --- never landed though since we're blocked mainly by Project-OSRM/node-osrm#153. |
Reopening this issue as it is about Next step: try with |
Errors with
|
@BergWerkGIS - this above looks familiar, was boost-regex built with correct ICU etc ? |
I think I found the problem, seems something has changed with boost build. Investigating ... |
ha, found the real reason: utility |
Got a successful
Still trying to figure out why Probably a typo in one of the scripts or jam files. rsp/manifest files:
Interesting that |
Couldn't find any error messages of failed After un-commenting
|
Alright, I'm down to the root cause: I created a new VS2015 solution based on Running it I get |
Before I pointed Pointing Next, looking into making boost find icu again. |
Finally 🎉 works again with
Takeaways/cc @springmeyer wrt https://github.com/mapnik/mapnik-packaging/blob/master/osx/patches/boost_icu_check.diff
Commit f85b64e |
Thank you thank you thank you @BergWerkGIS |
|
refs
mapnik/mapnik#3333
mapnik/mapnik-packaging@c2b4603
@springmeyer seeing this on Windows:
The text was updated successfully, but these errors were encountered: