Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate keyframes in css file #1378

Closed
maxlibin opened this issue Jul 18, 2022 · 3 comments
Closed

Duplicate keyframes in css file #1378

maxlibin opened this issue Jul 18, 2022 · 3 comments

Comments

@maxlibin
Copy link
Contributor

maplibre-gl-js version: Main branch

looks like there are quite a few css duplications for keyframes maplibregl-spin from: https://github.com/maplibre/maplibre-gl-js/blob/main/src/css/maplibre-gl.css#L467

line 467 - 485

maplibregl-user-location-dot-pulse https://github.com/maplibre/maplibre-gl-js/blob/main/src/css/maplibre-gl.css#L900

line 900 - 910

happy to help to cleanup if is true.
@HarelM
Copy link
Collaborator

HarelM commented Jul 18, 2022 •
edited
Loading

Strange... Feel free to send a PR to clean them.
It would also be helpful if you could find out when they were duplicated...

@maxlibin
Copy link
Contributor Author

Strange... Feel free to send a PR to clean them. It would also be helpful if you could find out when they were duplicated...

It was committed from this PR: #1004

@maxlibin maxlibin mentioned this issue Jul 19, 2022
Merged
@HarelM
Copy link
Collaborator

HarelM commented Jul 19, 2022

Ahh, now I understand, thanks!!

@HarelM HarelM closed this as completed in 6b72791 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxlibin @HarelM