Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript]: Single quotes versus double quotes #258

Closed
wipfli opened this issue Aug 28, 2021 · 1 comment
Closed

[typescript]: Single quotes versus double quotes #258

wipfli opened this issue Aug 28, 2021 · 1 comment

Comments

@wipfli
Copy link
Contributor

wipfli commented Aug 28, 2021

We use a mixture of single quotes and double quotes for strings, e.g. 'hello' and "world". This passes linting because our .eslintrc file has the flag "quotes": "off".

Let's remove this flag once the typescript branch has been merged, run npm run lint -- --fix and just use single quotes everywhere.
This was referenced Aug 28, 2021
Merged
Merged
@drwestco drwestco mentioned this issue Aug 31, 2021
Merged
9 tasks
@wipfli
Copy link
Contributor Author

wipfli commented Aug 31, 2021

Closed by #285

@wipfli wipfli closed this as completed Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wipfli