Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accessibility] The × character in the close button of popups should be explicitly hidden from ATs #360

Closed
Malvoz opened this issue Sep 18, 2021 · 2 comments
Labels

Comments

@Malvoz
Copy link
Contributor

Malvoz commented Sep 18, 2021

Although the contents of aria-label overrides the × character in the close button of popups, it is still announced as multiplication or times (depending on the screen reader) when the user is hovering the control with a mouse pointer.

To solve this issue, the × character:

this._closeButton.innerHTML = '×';

should be wrapped in <span aria-hidden="true">.

(This would also align and be more consistent with other controls that hide icons from ATs, such as the zoom in control)

DOM.create('span', 'maplibregl-ctrl-icon mapboxgl-ctrl-icon', this._zoomInButton).setAttribute('aria-hidden', 'true');


(The same issue was also reported with MapBox: mapbox/mapbox-gl-js#11035.)

@github-actions
Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Mar 18, 2022
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant