Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish to JSR #3804

Open
birkskyum opened this issue Mar 6, 2024 · 4 comments
Open

publish to JSR #3804

birkskyum opened this issue Mar 6, 2024 · 4 comments
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed

Comments

@birkskyum
Copy link
Member

It would be great to get on the JSR registry as it's taking off.

Since it's esm-only this is blocked by:

@HarelM
Copy link
Collaborator

HarelM commented Mar 6, 2024

Thanks for sharing!
I think we might be able to try again and export an esm build now that I have removed the global object.
If it's only adding another entry in the rollup config it should be failry easily.
I don't know about the other part related to JSR and I'll be surprised if we could upload the code "as is", maybe the csp code can be uploaded as it's "less complicated" I believe, IDK, would be interesting to try out.

@HarelM HarelM added enhancement New feature or request PR is more than welcomed Extra attention is needed labels Mar 6, 2024
@birkskyum
Copy link
Member Author

birkskyum commented Mar 6, 2024

It's a bit early, so I think it'll be significantly harder at this point to land jsr support than manually making the esm bundles (#1595), because jsr.io want to take .ts source code and make a analyze it, do a build, .d.ts, docs, etc., and I don't know how it'll will handle our need for multiple bundles (worker bundle etc.) - if it can read our rollup.config. They kinda have to support that, but I don't know if they do at this point.

@HarelM
Copy link
Collaborator

HarelM commented Mar 6, 2024

Yeah, although if we still need a rollup.config file and all we get is d.ts file and API docs (and if I needed to guess they probably are using the same tools we are using - dts bundle generator or api-extractor, and typedoc) then there's not a lot of added value here.
But it probably can't hurt to keep an eye on this.

@louwers
Copy link
Collaborator

louwers commented Oct 27, 2024

Sent an invite to @birkskyum for the @maplibre scope on JSR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants