Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump majors of point-geometry, pbf, vector-tile #4735

Open
birkskyum opened this issue Sep 21, 2024 · 1 comment
Open

Bump majors of point-geometry, pbf, vector-tile #4735

birkskyum opened this issue Sep 21, 2024 · 1 comment

Comments

@birkskyum
Copy link
Member

birkskyum commented Sep 21, 2024

These three packages by mapbox all have new major version updates that support ESM and don't support CJS. They seem to be very related and easiest to updated at the same time:

These two has to be removed at the same time, since the typescript is moved to the packages and will conflict:

  • "@types/mapbox__point-geometry": "^0.1.4",
  • "@types/mapbox__vector-tile": "^1.3.4",

When updating, there're some type errors, but the only non-trivial one is from geojson_wrapper.ts saying:

Class 'FeatureWrapper' incorrectly implements class 'VectorTileFeature'. Did you mean to extend 'VectorTileFeature' and inherit its members as a subclass?
  Type 'FeatureWrapper' is missing the following properties from type 'VectorTileFeature': _pbf, _geometry, _keys, _values, bboxts(2720)

Related to

@birkskyum birkskyum changed the title Bump point-geometry, pbf, vector-tile Bump majors of point-geometry, pbf, vector-tile Sep 21, 2024
@HarelM
Copy link
Collaborator

HarelM commented Sep 22, 2024

There is a branch I updated from dependabot to solve this, but one of the packages was not updated in one of the dependencies, causing a significant bundle size increase.
I'm not sure I had a good solution to this, but feel free to take a stab at this.

See here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants