-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3103 added showButton option to GeoLocate control. #4134
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
==========================================
+ Coverage 86.70% 86.82% +0.11%
==========================================
Files 242 242
Lines 33044 33049 +5
Branches 2001 2132 +131
==========================================
+ Hits 28652 28695 +43
+ Misses 3432 3401 -31
+ Partials 960 953 -7 ☔ View full report in Codecov by Sentry. |
I have outlined what I believe should be the right solution - refactoring the state management logic out so that it can be reused with other UI controls. |
I fix to use css. |
As I wrote, CSS can be used without any chance to this library code. |
#3103 added
showButton
option to GeoLocate control.Launch Checklist
CHANGELOG.md
under the## main
section.