Fix level of detail at high pitch

[NathanMOlson]

This (failing) unit test demonstrates the issue reported here: #3983 and #4703

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.35%. Comparing base (718e0cb) to head (c4a1995).

Files with missing lines	Patch %	Lines
src/geo/transform.ts	84.61%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4741      +/-   ##
==========================================
- Coverage   87.95%   86.35%   -1.61%     
==========================================
  Files         247      247              
  Lines       33656    33663       +7     
  Branches     2165     2237      +72     
==========================================
- Hits        29603    29068     -535     
- Misses       3082     3517     +435     
- Partials      971     1078     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NathanMOlson]

This fixes #3983 and improves #4703 by calculating the desired zoom level for each tile independently. Each tile zoom is calculated by scaling the center point zoom by the ratio of (3D) distance-to-tile to distance-to-center. Old behavior is preserved when there is no terrain and pitch < 60 degrees.

Before at 70 degrees pitch:

After:

Before at 80 degrees pitch:

After:

[HarelM]

Thanks for taking the time to open this PR!
We are working on the globe branch where we moved a lot of the tile fetching logic to a different file.
There are two options here from my point of view:

1. Merge this to main and then merge/rewrite this in globe branch.
2. Merge this to globe branch and wait for version 5 release.

Let me know which works better for you.

Can you also show before and after of the showtilesboundries when terrain is disabled?

[NathanMOlson]

The previously-posted images are with terrain disabled. Here is the before/after with terrain enabled:

Before:

After:

[NathanMOlson]

Thanks for taking the time to open this PR! We are working on the globe branch where we moved a lot of the tile fetching logic to a different file. There are two options here from my point of view:

1. Merge this to main and then merge/rewrite this in globe branch.
2. Merge this to globe branch and wait for version 5 release.

Let me know which works better for you.

I just took a look at the globe branch and it looks like there's been some extensive rearrangement. So I think this will need a rewrite either way. Given that there will be no new 4.x releases, I don't see a reason to merge it to main. I'll work on moving it to globe.

[HarelM]

I can carve out a new release if 4.x if this is something you absolutely need, but I would prefer to simply move this to 5.x if this is not urgent for you as it might take around 2 month to release a stable 5.x version.

[NathanMOlson]

I'm happy to move this to 5.x.

[NathanMOlson]

Superceded by #4750