Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create iOS size test #943

Closed
alexcristici opened this issue Mar 27, 2023 · 8 comments · Fixed by #984
Closed

Create iOS size test #943

alexcristici opened this issue Mar 27, 2023 · 8 comments · Fixed by #984
Assignees

Comments

@alexcristici
Copy link
Collaborator

Investigating a way to measure the size of the framework after being linked to the demo app.

@alexcristici alexcristici self-assigned this Mar 27, 2023
@roblabs
Copy link
Collaborator

roblabs commented Mar 27, 2023

@alexcristici

A potentially useful reference on measuring framework size: #19 (comment)

@louwers
Copy link
Collaborator

louwers commented Mar 28, 2023

@alexcristici on Slack

Regarding the size test, I see 2 tests:
1 Building the dynamic iOS target to generate the framework, the size now is around 5.5 Mb
2 Archive and distribute the iosapp and check the app-thinning.plist , compressed and uncompressed sizes

For option 2 in order to archive and distribute we need valid certificates and provisioning for signing the package

@wipfli Can we sign up for the Apple Developer Program as MapLibre? https://developer.apple.com/programs/enroll/

@roblabs
Copy link
Collaborator

roblabs commented Mar 28, 2023

@wipfli Can we sign up for the Apple Developer Program as MapLibre? https://developer.apple.com/programs/enroll/

Maybe MapLibre can be considered an eligible org:

[Apple Developer Program Membership Fee Waivers] https://developer.apple.com/support/membership-fee-waiver "Apple Developer Program membership is available at no cost for eligible organizations. Find out if your organization qualifies and how to request a waiver."

@louwers
Copy link
Collaborator

louwers commented Mar 29, 2023

@roblabs Nice find! In any case OSC needs to be involved because it's only available for legal entities.

@wipfli
Copy link
Contributor

wipfli commented Apr 3, 2023

I wrote Open Source Collective, MapLibre's fiscal host, if they can join the Apple Developer Program if they are not part yet. Will keep you updated.

@alexcristici alexcristici linked a pull request Apr 4, 2023 that will close this issue
@wipfli
Copy link
Contributor

wipfli commented Apr 12, 2023

Open Source Collective will not sign us up for the Apple Developer Program, because Apple would give them only one account which they would need to share with all projects.

We have paid now for 1 year a private account for @louwers which I think is good enough for CI. What do you think?

In any case, @louwers please document the CI setup here in readme files in this repository. The credentials itself should be stored in our password manager.

@ntadej
Copy link
Collaborator

ntadej commented Apr 12, 2023

If it helps, I use https://github.com/fastlane/fastlane quite successfully for CI due to automation.

@louwers
Copy link
Collaborator

louwers commented Apr 12, 2023

@wipfli I will set up the provisioning profile on CI, but I cannot obviously not share my private Apple ID credentials. But I think that is not what you meant.

Apple would give them only one account which they would need to share with all projects

I think you can set up sub-accounts?

If it helps, I use fastlane/fastlane

We still need an account enrolled to the Apple Developer Programme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants