You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think we need tracer_module_name element in marbl_tracer_metadata_type or any of the marbl_tracer_count_type objects in marbl_tracer_index_type (or the marbl_tracer_count_type derived type itself).
The only use for tracer_module_name is letting the users know which tracers came from which modules, which doesn't seem like a necessary feature. The indices in the marbl_tracer_count_type were used to set specific fluxes and tendencies to zero before computing them, but we set the full arrays to zero at the beginning of the respective _compute() functions so those calls were redundant. There is also some information about each tracer module in the log:
base biotic tracers tracer module contains 32 tracers; indices are 1 to 32
abio tracer module contains 2 tracers; indices are 47 to 48
ciso tracer module contains 14 tracers; indices are 33 to 46
but do we really need to provide this information at runtime?
The text was updated successfully, but these errors were encountered:
I don't think we need
tracer_module_name
element inmarbl_tracer_metadata_type
or any of themarbl_tracer_count_type
objects inmarbl_tracer_index_type
(or themarbl_tracer_count_type
derived type itself).The only use for
tracer_module_name
is letting the users know which tracers came from which modules, which doesn't seem like a necessary feature. The indices in themarbl_tracer_count_type
were used to set specific fluxes and tendencies to zero before computing them, but we set the full arrays to zero at the beginning of the respective_compute()
functions so those calls were redundant. There is also some information about each tracer module in the log:but do we really need to provide this information at runtime?
The text was updated successfully, but these errors were encountered: