Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nlm_curds & nlm_wheys #16

Closed
marcosci opened this issue Mar 1, 2018 · 0 comments
Closed

nlm_curds & nlm_wheys #16

marcosci opened this issue Mar 1, 2018 · 0 comments
Assignees

Comments

@marcosci
Copy link
Collaborator

marcosci commented Mar 1, 2018

ropensci/software-review#188 (comment):

No checkmate tests at the beginning.

There is borrowed code between these two. It might make sense to combine them (with a wheys T/F option), or to use the nlm_curds function inside nlm_wheys instead of repeating the code.

These seem quite different in the way they are written to the other functions. Primarily in that the others all specify nrow, ncol, resolution, whereas these specify extent. Is it possible to harmonise these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants