Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vim] Make vim dialog work correctly #1509

Closed
wants to merge 1 commit into from
Closed

[vim] Make vim dialog work correctly #1509

wants to merge 1 commit into from

Conversation

njx
Copy link
Contributor

@njx njx commented May 7, 2013

Currently, running a vim command like :w doesn't work--it throws an exception when closing the dialog because it tries to call callback, which doesn't exist. If I'm understanding the code correctly, it should call onClose instead.

(It looks like this code has been in there for a long time, so I'm not sure why this hasn't caused a problem before--maybe no one is using the default implementation of openDialog().)

@mightyguava
Copy link
Contributor

You are right, my bad. Thanks for the fix.

@marijnh
Copy link
Member

marijnh commented May 8, 2013

Thank you. Merged.

@marijnh marijnh closed this May 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants