[vim] Make vim dialog work correctly #1509
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running a vim command like
:w
doesn't work--it throws an exception when closing the dialog because it tries to callcallback
, which doesn't exist. If I'm understanding the code correctly, it should callonClose
instead.(It looks like this code has been in there for a long time, so I'm not sure why this hasn't caused a problem before--maybe no one is using the default implementation of
openDialog()
.)