Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link resolution failed #1268

Closed
JaxsonWang opened this issue May 12, 2018 · 5 comments
Closed

Link resolution failed #1268

JaxsonWang opened this issue May 12, 2018 · 5 comments
Labels
question
Milestone
0.4.0 - Various f...

Comments

@JaxsonWang
Copy link

JaxsonWang commented May 12, 2018 •
edited
Loading

see this demo

or this demo

If the link contains () it will fail to parse. Thanks for solving this problem.
@JaxsonWang JaxsonWang mentioned this issue May 12, 2018
Closed
@styfle styfle added the L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue label May 13, 2018
@styfle
Copy link
Member

styfle commented May 13, 2018

Thanks for the bug report!

I confirmed that this is a bug in marked, and works fine in CommonMark.

@UziTech
Copy link
Member

UziTech commented May 14, 2018

@Feder1co5oave wasn't #1135 supposed to fix this?

@Feder1co5oave
Copy link
Contributor

Feder1co5oave commented May 14, 2018 •
edited
Loading

Is this relative to master? I don't think that pr was released yet?
It should support up to one level of nested, balanced parenthesis, yes.

@Feder1co5oave
Copy link
Contributor

That demo uses the latest released version, the bug is fixed in master:

$ bin/marked
[wd](https://aaa.com/(wd))

[demo](https://wiki.archlinux.org/index.php/Samba_(简体中文)#.E6.B7.BB.E5.8A.A0.E7.94.A8.E6.88.B7)

<p><a href="https://aaa.com/(wd)">wd</a></p>
<p><a href="https://wiki.archlinux.org/index.php/Samba_(%E7%AE%80%E4%BD%93%E4%B8%AD%E6%96%87)#.E6.B7.BB.E5.8A.A0.E7.94.A8.E6.88.B7">demo</a></p>

Please make sure the bug is still there before confirming it.

@styfle styfle removed the L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue label May 17, 2018
@styfle styfle added this to the 0.4.0 - No known defects milestone May 17, 2018
@styfle
Copy link
Member

styfle commented May 17, 2018

I confirmed this is fixed in master and will be released in 0.4.0

@styfle styfle mentioned this issue May 17, 2018
Closed
@styfle styfle changed the title bug:Link resolution failed Link resolution failed May 17, 2018
@joshbruce joshbruce mentioned this issue May 20, 2018
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
0.4.0 - Various fixes & Commonmark co...
Development

No branches or pull requests
4 participants
@UziTech @styfle @Feder1co5oave @JaxsonWang