Last closing round bracket is stripped out from the href

[teimurjan]

Describe the bug

The last ) is stripped out from the href when rendering HTML.

It works fine on CommonMark.

To Reproduce
Steps to reproduce the behavior:

marked receives the following content: testText https://test.test?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:'2015-10-11T11:08:59.548Z',mode:absolute,to:'2015-10-11T11:23:59.548Z'))&_a=(columns:!(URL),index:logs_web_error,interval:auto,,sort:!(TimeStamp,desc)). Instead of having the anchor element with this whole link I get:

<a href="https://test.test?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:'2015-10-11T11:08:59.548Z',mode:absolute,to:'2015-10-11T11:23:59.548Z'))&_a=(columns:!(URL),index:logs_web_error,interval:auto,,sort:!(TimeStamp,desc)">https://test.test?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:'2015-10-11T11:08:59.548Z',mode:absolute,to:'2015-10-11T11:23:59.548Z'))&_a=(columns:!(URL),index:logs_web_error,interval:auto,,sort:!(TimeStamp,desc)</a>)</p>

The last ) is lost from the href somehow.

1. Marked Demo
2. CommonMark Demo

Expected behavior
Expected not to have the last ) stripped from href.

[teimurjan]

The problem caused by the usage of this regex.

Testing the Regex.

[teimurjan]

If someone could explain me what is the purpose of this regexp, I'd fix the issue by myself

[UziTech]

The purpose of that is to prevent urls from including punctuation.

e.g.

(https://example.com)
My website is https://example.com.
https://example1.com, https://example2.com, https://example3.com

)., in those examples should not be part of the url

It is very difficult to determine what should be and what should not be part of a url.

My website is https://example.com?web=site!

Should ! be included in the url? Maybe it is part of the query? There is no way of knowing which is why common mark only includes urls surrounded by <> as links.

[UziTech]

The fix would be to wrap your urls with <> demo

[teimurjan]

@UziTech Thanks, got it. But to be absolutely calm, why is it working at CommonMark?

[UziTech]

It's not working on your CommonMark Demo. If you view the html you will see that it doesn't set it as a link because autolinking is in the gfm spec not the commonmark spec.

[UziTech]

To be clear, this is actually a bug in marked because matched parenthesis should be part of the link but just changing the _backpedal regex isn't going to fix that. We should be using findClosingBracket similar to links

[tmorehouse]

I'm seeing similar issues when we convert our changelog to HTML (we are using standard-version to genreate the changelog):

(fixes [#3025](https://github.com/bah/blah/issues/3025)) ([#3029](https://github.com/bah/blah/pull/3029)) ([ad57e8c](https://github.com/bah/blah/commit/ad57e8c))

becomes

(fixes <a href="https://github.com/bah/blah/issues/3025">#3025</a> (<a href="https://github.com/bah/blah/pull/3029">#3029</a> (<a href="https://github.com/bah/blah/commit/ad57e8c">ad57e8c</a>)

which renders visually as

(fixes #3025 (#3029 (ad57e8c)

which is missing the expected closing brackets, and should be rendered as:

(fixes #3025) (#3029) (ad57e8c)

It used to work several versions ago, but I think the issue was introduced in #1435 or #1414

[UziTech]

@tmorehouse Your case is a little bit different since it is missing a parenthesis around the link not inside the link.

I created PR #1509 to fix this