Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DHFPROD-590 and DHFPROD-1698 #1741

Merged
merged 2 commits into from
Jan 11, 2019

Conversation

srinathgit
Copy link
Contributor

This PR

  1. Populates 'errors' and 'hasErrors' objects when there are changes to the code
  2. Places the bug icon on the right line (unsure why they are off by one line currently)

@ayuwono
Copy link
Contributor

ayuwono commented Jan 11, 2019

On initial UI testing, the bug icon appears again on the error line

@aebadirad aebadirad merged commit 3f8f149 into Marklogic-retired:develop Jan 11, 2019
aebadirad pushed a commit that referenced this pull request Jan 18, 2019
* Populating 'errors' and 'hasErrors' object (Fix for DHFPROD-1698)

* Place bug icon on the correct line (DHFPROD-1698)
aebadirad added a commit that referenced this pull request Jan 18, 2019
* Test docs for ES alignment

* Move entity management logic from QS to core lib (#1735)

* Move enitiy management logic from QS to core lib

* Update tests to not rely on list order for comparison

* Save the entity on disk

* Add triggers for entity model TDE generation (#1734)

* Support for ES models in content creation (#1738)

* Support for content creation with ES models

* Fixing variable assignment and indentation

* Incorporate referenced entity model definitions in same definitions (#1739)

* Add triggers for entity model TDE generation

* Combine referenced entities into a single entity model

* Es alignment - Fix failing tests (#1747)

* Add triggers for entity model TDE generation

* Combine referenced entities into a single entity model

* Add triggers folder to upgrade test example

* Adjust TDEs to be more forgiving

* Retain namespaces when creating search options

* Clean up entity models after loading them

* Create 'LoadUserArtifactsCommand' for loading entities, mappings (#1755)

* Prevent mappings files being loaded to the hub modules db

* Create a separate command for loading user artifacts

* Create corresponding gradle command for loading user artifacts

* Run 'LoadUserArtifactsCommand' after 'LoadUserModulesCommand' is run

* Modify existing tests/ add new tests

* fixing #1736 (#1737)

* Updating test for DHFPROD-1581 (#1740)

* Fix for DHFPROD-590 and DHFPROD-1698 (#1741)

* Populating 'errors' and 'hasErrors' object (Fix for DHFPROD-1698)

* Place bug icon on the correct line (DHFPROD-1698)

* Setting content db to final db (#1744)

* Setting content db to final db

* Test to verify if content db is set to final db

*  Revert Spring boot version upgrade for QS (#1748)

* Revert "Upgrade Spring boot ver for QS (#1698)"

This reverts commit c2b1323

* Update authenticated.ts

* Update authenticated.ts

* 2019 copyright update (#1752)

* Updating gradle-dhs.properties to run DHF core tests in DHS (#1753)

* E2e/qs misc test (#1756)

* add po for invalid title alert

* add po for duplicate flowname alert

* add test for invalid char on entity title

* add test for duplicate flow names

* Move entity management logic from QS to core lib (#1735)

* Move enitiy management logic from QS to core lib

* Update tests to not rely on list order for comparison

* Save the entity on disk

* Create 'LoadUserArtifactsCommand' for loading entities, mappings (#1755)

* Prevent mappings files being loaded to the hub modules db

* Create a separate command for loading user artifacts

* Create corresponding gradle command for loading user artifacts

* Run 'LoadUserArtifactsCommand' after 'LoadUserModulesCommand' is run

* Modify existing tests/ add new tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants