Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for DHFPROD-1773, DHFPROD-1746 #1820

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Fix for DHFPROD-1773, DHFPROD-1746 #1820

merged 3 commits into from
Jan 30, 2019

Conversation

srinathgit
Copy link
Contributor

This PR fixes

  1. creates temp file with same name as entity file so that models written to final db by ml-app-deployer continue to have the same name as before and not get prepended by temp file name (/marklogic.com/entity-services/models/e2eentity.entity.json)
  2. DHFPROD-1773- handles NPE when entities are on disk and not in db

@srinathgit srinathgit changed the base branch from master to 4.x-develop January 30, 2019 00:53
@aebadirad aebadirad merged commit 175236b into Marklogic-retired:4.x-develop Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aebadirad aebadirad aebadirad approved these changes

@bsrikan bsrikan Awaiting requested review from bsrikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srinathgit @aebadirad