Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHFPROD-1788 Bring in other models for uber model in trigger #1843

Merged
merged 6 commits into from
Feb 13, 2019

Conversation

ryanjdew
Copy link
Contributor

@ryanjdew ryanjdew commented Feb 3, 2019

Properly build uber model as part of the entity services trigger and remove an unused class from a previous approach I was exploring the TDE gradle command.

@ryanjdew ryanjdew requested a review from bsrikan February 3, 2019 18:19
@bsrikan
Copy link
Contributor

bsrikan commented Feb 12, 2019

Verified the commits and they look good.

@aebadirad
Copy link
Contributor

Give an approving review and we'll merge.

Copy link
Contributor

@bsrikan bsrikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix hence approving

@aebadirad
Copy link
Contributor

@ryanjdew can i get a rebase please?

@ryanjdew
Copy link
Contributor Author

@aebadirad rebased

@aebadirad aebadirad merged commit 3a24932 into Marklogic-retired:4.x-develop Feb 13, 2019
@ryanjdew ryanjdew deleted the dhfprod-1788-4.x branch October 10, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants