Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dhfprod 1788 - develop PR #1844

Merged
merged 8 commits into from
Feb 13, 2019
Merged

Dhfprod 1788 - develop PR #1844

merged 8 commits into from
Feb 13, 2019

Conversation

ryanjdew
Copy link
Contributor

@ryanjdew ryanjdew commented Feb 3, 2019

No description provided.

@ryanjdew ryanjdew requested a review from bsrikan February 3, 2019 18:26
@bsrikan
Copy link
Contributor

bsrikan commented Feb 12, 2019

Verified the commits and they look good.

bsrikan
bsrikan approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@bsrikan bsrikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix hence approving

@aebadirad
Copy link
Contributor

@ryanjdew can i get a rebase please?

@ryanjdew
Copy link
Contributor Author

@aebadirad rebased

@aebadirad aebadirad merged commit eb6cf31 into Marklogic-retired:develop Feb 13, 2019
@ryanjdew ryanjdew deleted the dhfprod-1788-develop branch October 10, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsrikan bsrikan bsrikan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanjdew @bsrikan @aebadirad