219 - Fix Bugs in Load Data Feature #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also added validation for missing input file path
| @@ -237,6 +237,16 @@ | |||
| ] | |||
| } | |||
| ]; | |||
| angular.forEach(previousOptions, function(value, key) { | |||
| $.each(groups, function(i, group) { | |||
There was a problem hiding this comment.
please use angular.forEach... just in case we remove jQuery later.
| @@ -157,7 +177,9 @@ | |||
| } | |||
|
|
|||
| $scope.$watch('mlcp.input_file_path', function(value) { | |||
| searchPath(value); | |||
| if(isValidInputFilePath(value)) { | |||
There was a problem hiding this comment.
The first time you open this dialog ever you get the error right off the bat. We need to set a default value for input_file_path or something.
* master: Changes to fix JS errors in Swagger UI in master
brucean52
pushed a commit
to brucean52/marklogic-data-hub
that referenced
this pull request
Mar 2, 2020
…N/explorer-ui:dhrpod4369 to develop * commit '934a2d944d0b79b4a07a3f801465b7faff70b78f': updated Dockerfile for CI/CD pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix marklogic/datahub-central#1478
Kindly review.