fixed #633 #648
Merged
fixed #633 #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the internals for #536 because this task really needed it. Did not expose the stop on fail option to gradle or the UI
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
dmcassel
suggested changes
Jan 12, 2018
| @@ -0,0 +1,8 @@ | |||
| package com.marklogic.hub.error; | |||
|
|
|||
| public class HarmonizeFlowError extends Exception { | |||
There was a problem hiding this comment.
Error is actually a class in Java that is a subclass of Throwable. It's used to indicate "serious problems that a reasonable application should not try to catch" (link). Conversely, an Exception "indicates conditions that a reasonable application might want to catch".
This looks like it should be HarmonizeFlowException.
dmcassel
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the internals for marklogic/datahub-central#1180 because this task really needed it. Did not expose the stop on fail option to gradle or the UI