Issue 575 #649
Merged
Issue 575 #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
aebadirad
suggested changes
Jan 17, 2018
There was a problem hiding this comment.
@RobertSzkutak Since these are changes to functionality offered, could we also get an E2E test for protractor to run using a relative file path and a bad relative path so we know if something changes that breaks it?
|
@aebadirad When you say "bad" relative path are you referring to illegal filepath characters or a path that doesn't exist on the local filesystem? If the case of the latter, could you provide a reference on how that could be tested? |
aebadirad
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows input_file_path to be editable so that it may be modified to be relative.