Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#504 send options along with harmonization flows #654

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

dmcassel
Copy link
Contributor

No description provided.

@marklogic-builder
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@marklogic-builder
Copy link
Contributor

Can one of the admins verify this patch?

}
});

// Wait for the flow to finish
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the sync block here for waiting for it to complete. +1

@dmcassel dmcassel merged commit ddd3162 into develop Jan 16, 2018
@grechaw
Copy link

grechaw commented Jan 23, 2018

Hi @dmcassel , Mike had told me that this PR implemented the passing of target database... I don't think it does though. This PR pushes options down into the headers of the harmonized document, but the code that chooses target database doesn't look in the options to do anything. Is there some oversight? I'm trying to help Mike connect the dots from the UI to the services, and to understand the codebase better myself.

@dmcassel
Copy link
Contributor Author

@grechaw it doesn't ... it allows users to pass along arbitrary options that will be used in a harmonization flow. The framework itself pays no attention to them. That was the goal of marklogic/datahub-central#1211.

@grechaw
Copy link

grechaw commented Jan 24, 2018

Thanks Dave for that confirmation. I think all the folks are on the same page about this request now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants