Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHFPROD-274 put sample data and model into an example project. #728

Merged
merged 3 commits into from
Feb 9, 2018
Merged

DHFPROD-274 put sample data and model into an example project. #728

merged 3 commits into from
Feb 9, 2018

Conversation

grechaw
Copy link

@grechaw grechaw commented Feb 9, 2018

Here's the PR for the github side of the world, adding an example project with data for front-end developers.

@marklogic-builder
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@marklogic-builder
Copy link
Contributor

Can one of the admins verify this patch?

settings.gradle Outdated
@@ -3,4 +3,5 @@ include ':marklogic-data-hub'
include ':ml-data-hub-plugin'
include ':quick-start'

include ':examples:data-integration-tests'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grechaw what's the advantage to adding this here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It made IDEA recognize that project. However if it causes any issues at all then of course it should be removed; now that that example works from the command line, I don't think it's needed as an explicit subproject.

@marklogic-builder
Copy link
Contributor

Jenkins Build failure
http://jenkins.marklogic.com/job/Labs/job/DHF_b9_nightly_linux_cluster/70/testReport

No test results found.

@paxtonhare paxtonhare merged commit 5048fc5 into Marklogic-retired:develop Feb 9, 2018
@marklogic-builder
Copy link
Contributor

Jenkins Build failure
http://jenkins.marklogic.com/job/Labs/job/DHF_b9_nightly_linux_cluster/74/testReport

1 tests run, 0 skipped, 1 failed.

@marklogic-builder
Copy link
Contributor

Jenkins Build failure
http://jenkins.marklogic.com/job/Labs/job/DHF_b9_nightly_linux_cluster/76/testReport

1 tests run, 0 skipped, 1 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants