Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing tracing stuff #749

Merged
merged 2 commits into from
Feb 20, 2018
Merged

fixing tracing stuff #749

merged 2 commits into from
Feb 20, 2018

Conversation

paxtonhare
Copy link
Contributor

No description provided.

@marklogic-builder
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@marklogic-builder
Copy link
Contributor

Can one of the admins verify this patch?

@@ -610,7 +610,7 @@ declare function trace:get-traces($page as xs:int, $page-length as xs:int)
let $end := $start + $page-length - 1
let $count := xdmp:estimate(/trace)
let $traces :=
for $trace in cts:search(/trace, cts:true-query(), ("unfiltered", cts:index-order(cts:element-reference(xs:QName("created")), "descending")))[$start to $end]
for $trace in cts:search(/trace, cts:true-query(), ("unfiltered", cts:index-order(cts:path-reference("/trace/created"), "descending")))[$start to $end]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has the traceDB config been updated to add this path range index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it never had a range index. dunno how it ever worked.

@@ -628,8 +628,7 @@ declare function trace:get-trace($id as xs:string)
{
let $query :=
cts:or-query((
cts:element-range-query(xs:QName("traceId"), "=", $id, ("collation=http://marklogic.com/collation/codepoint")),
cts:json-property-range-query("traceId", "=", $id, ("collation=http://marklogic.com/collation/codepoint"))
cts:path-range-query("/trace/traceId", "=", $id, ("collation=http://marklogic.com/collation/codepoint"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has the traceDB config been updated to add this path range index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never had this other index.

xs:QName("identifier"),
cts:value-co-occurrences(
cts:path-reference("/trace/traceId"),
cts:path-reference("/trace/identifier"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has the traceDB config been updated to add this path range index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@marklogic-builder
Copy link
Contributor

Jenkins Build failure
http://jenkins.marklogic.com/job/Labs/job/DHF_b9_nightly_linux_cluster/127/testReport

480 tests run, 0 skipped, 2 failed.

@marklogic-builder
Copy link
Contributor

Jenkins Build failure
http://jenkins.marklogic.com/job/Labs/job/DHF_b9_nightly_linux_cluster/129/testReport

480 tests run, 0 skipped, 2 failed.

@paxtonhare paxtonhare merged commit 2430b3d into develop Feb 20, 2018
@aebadirad aebadirad deleted the fix_trace_rewriter branch March 6, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants