-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing tracing stuff #749
fixing tracing stuff #749
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
@@ -610,7 +610,7 @@ declare function trace:get-traces($page as xs:int, $page-length as xs:int) | |||
let $end := $start + $page-length - 1 | |||
let $count := xdmp:estimate(/trace) | |||
let $traces := | |||
for $trace in cts:search(/trace, cts:true-query(), ("unfiltered", cts:index-order(cts:element-reference(xs:QName("created")), "descending")))[$start to $end] | |||
for $trace in cts:search(/trace, cts:true-query(), ("unfiltered", cts:index-order(cts:path-reference("/trace/created"), "descending")))[$start to $end] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has the traceDB config been updated to add this path range index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it never had a range index. dunno how it ever worked.
@@ -628,8 +628,7 @@ declare function trace:get-trace($id as xs:string) | |||
{ | |||
let $query := | |||
cts:or-query(( | |||
cts:element-range-query(xs:QName("traceId"), "=", $id, ("collation=http://marklogic.com/collation/codepoint")), | |||
cts:json-property-range-query("traceId", "=", $id, ("collation=http://marklogic.com/collation/codepoint")) | |||
cts:path-range-query("/trace/traceId", "=", $id, ("collation=http://marklogic.com/collation/codepoint")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has the traceDB config been updated to add this path range index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never had this other index.
xs:QName("identifier"), | ||
cts:value-co-occurrences( | ||
cts:path-reference("/trace/traceId"), | ||
cts:path-reference("/trace/identifier"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has the traceDB config been updated to add this path range index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Jenkins Build failure 480 tests run, 0 skipped, 2 failed. |
Jenkins Build failure 480 tests run, 0 skipped, 2 failed. |
No description provided.