Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/lib/Object.assign not in react 0.15 #14

Closed
jdart opened this issue Apr 8, 2016 · 4 comments
Closed

react/lib/Object.assign not in react 0.15 #14

jdart opened this issue Apr 8, 2016 · 4 comments

Comments

@jdart
Copy link

jdart commented Apr 8, 2016

Module not found: Error: Cannot resolve module 'react/lib/Object.assign' in .../node_modules/react-css-transition-replace/lib

Apparently the react team suggests using lodash/underscore for utility functions now.

@marnusw
Copy link
Owner

marnusw commented Apr 9, 2016

Thanks for pointing this out @jdart. Would you mind providing a link to the source of the React team's recommendation? I would like to include the reference in the change log when I add the lodash dependency.

@jdart
Copy link
Author

jdart commented Apr 9, 2016

I think this is the main discussion: facebook/react#6376

Apparently you could use the spread operator instead of Object.assign. React is now using the npm package object-assign.

@jdart
Copy link
Author

jdart commented Apr 9, 2016

There's a nice workaround here from @pascalpp react-ga/react-ga#53

@marnusw
Copy link
Owner

marnusw commented Apr 9, 2016

It looks like React is including the object-assign lib now so I've opted to do the same here. The change is available in v1.1.2.

@marnusw marnusw closed this as completed Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants