Merge Maven main module into ui module #1254
Conversation
Chnages: - Remove unused plugins and dependencies from pom files - Remove use of customer repositories - Upgrade version to '3.8.0-pre' Part of #1241
WalkOutsideTest can randomly fail when run in GitHub. It is because the tests are not thread safe because ofthe use of the LocalObject cacge which is cleared down by all the tests. This means tests can interfere with each other.
Changes: - Move the MarsProject from the main to ui Maven module - Updated the pom of ui module so it builds the executable jar - assembly.xml picks Jar out of the UI module - dist & gdx module has update dependency to the ui module - moved all the Eclipse launch files from main to ui Note the main module folder still exists but this can be deleted soon as a tidy up. Part of #1241
| @@ -148,7 +147,6 @@ | |||
| <modules> | |||
| <module>mars-sim-tools</module> | |||
| <module>mars-sim-mapdata</module> | |||
| <module>mars-sim-main</module> | |||
There was a problem hiding this comment.
So, the maven submodule mars-sim-main have no use now ?
|
That's a big change ! I wonder if you still want |
Yes, this is the first change. Next is to combine tools, map data and core. |
Yes. After I choose "Update Project" under "Maven", things got sync-ed. It works. |
Somehow I find it uncomfortable to develop mars-sim in IntelliJ. But I'd love to see how easy mars-sim can be set up for development in VSCode. This way, I don't have to depend on Eclipse forever. |
VSCode is pretty good. I switched over a year ago. I found Eclipse was getting slower. Will consolidate the core module next. Overall,this will simplify the build. |
This PR consists of 3 major changes:
The 'main' module folder is till left but this can be removed.
Note, this change may need a reload of the project in Eclipse. VSCode is fine.