Relocate Tasks for Building & Functions #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Create subpackage 'task' under building and building/function - Move appropriate Task & MetaTask to the new packages Part of #1285
Changes: - Create 2 new Unit Tests - Allow MockBuilding to excluded life support - Simplify buildFunction method in AbstractMarsSimUnitTest; Building id auto generated - MockBuilding has a maintenance period by default - MalfunctionManager remove unused methods - MalfunctionManager exposes the number of completed maintenance Part of #1285
Changes: - Create UnitTest for HouseKeeping class - HouseKeeping records the cumulative work - Create new TendHousekeeping Task that perform the inspect & cleaning operations - TendFishTank, TendAlgaePond & TendGreenhouse arre subclassed from new TendHousekeeping class - Remove duplicated base code from subclasses - Greenhouse, Fishery & AlgaeFarming expose the HouseKeeping attribute but remove the repeated delegated methods - Update relevant Console conmand - Farming category tasks use the ExperiemceImpact handles logic Note this a problem in the Research class and how it handles tissue needing inspection because nothing never gets added Plus the Crop logic should not be in the generic Research class. See #1312 Part of #1285
bevans2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on the Task associated with Buildings. Following the #1285 objectives it does:
The scope is the maintain building Tasks and the Tasks associated to the Farming category.