Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Implications? #372

Open
KeKs0r opened this issue Aug 2, 2015 · 2 comments
Open

Performance Implications? #372

KeKs0r opened this issue Aug 2, 2015 · 2 comments

Comments

@KeKs0r
Copy link

KeKs0r commented Aug 2, 2015

Hi,

I migrated my app from a simple Flux app to marty and react-router. After that migration and some refactoring I am experiencing a heavy performance loss. I am mainly concerned with page transitions that are especially on android phones very laggy. Almost unbearable.

I have already tried a lot to optimize, but the general thing is something I cant get my head around, since its almost the same app with same data / views etc, but now its just very laggy. I don't think that marty or something itself is slow, but maybe a heavy use of marty containers or something would make the app slow.

Has someone maybe some advice. I have already done all the normal react optimization and even with 2 days of work to optimize the rendering of a single view tree is not having a real impact compared to how the app worked out of the box before.

@taion
Copy link
Member

taion commented Aug 2, 2015

As a general rule it's not a bad idea to limit the number of event emitters. Where does the profiler say time is going?

@KeKs0r
Copy link
Author

KeKs0r commented Aug 3, 2015

I am puzzled by this a lot. One of the confusing thins is as simple as showing the wasted time in renders. Where I see that one component is rendered several times where it did not end up in changing the dom. And this component seems slightly expensive. The issue is, when debugging it the component is exactly rendered once and shouldComponentUpdate, is not called at all during the transaction I am tracking.

I even created an issue for it, but could not yet reproduce it in a simpler environment:
facebook/react#4462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants