Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code reuse and license compliance #192

Closed
nickdesaulniers opened this issue Sep 26, 2013 · 0 comments
Closed

Code reuse and license compliance #192

nickdesaulniers opened this issue Sep 26, 2013 · 0 comments

Comments

@nickdesaulniers
Copy link

@martynsmith , I modified node-irc and am using it clientside in an Firefox OS IRC client app. Our new/young/immature TCP socket interface has some differences from Node (which I'll argue to resolve internally), but other than a few lines to shim out the differences it works! We include my fork of node-irc as a git submodule.

I had two quick questions:

  1. We've included a copy of the GPLv3 and added a license header block to our code, acknowledging your copyright. Is this sufficient?
  2. The modified fork isn't in shape to be contributed back upstream. Under the GPL, am I required to upstream my changes?
@osslate osslate closed this as completed May 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants